addcomputer.py Does not set machine object attributes (dnsHostName, SPNs, etc) when creating over SAMR · fortra/impacket#1077

(5 留言) (0 反應) (0 負責人)Python (12,244 star) (3,421 fork)batch import

enhancementhelp wanted

描述

Configuration

Debug Output With Command String

python3 addcomputer.py evilcorp.local/leon:<password> -method SAMR -computer-name rbcdFromLinux -computer-pass Password123 -dc-host dc01.evilcorp.local -dc-ip 192.168.2.10 -debug
Impacket v0.9.23.dev1+20210504.123629.24a0ae6f - Copyright 2020 SecureAuth Corporation

[+] Impacket Library Installation Path: /home/b1gbroth3r/.local/lib/python3.8/site-packages/impacket
[*] Opening domain EVILCORP...
[*] Successfully added machine account rbcdFromLinux$ with password Password123.

Additional context

The expected result is to have a new computer object created with the populated attributes being set on lines 217 -229. However, querying the new object with pywerview or viewing it in the GUI from the DC reveals this output:

accountexpires:         never
badpasswordtime:        1600-12-31 18:00:00
badpwdcount:            0
cn:                     rbcdFromLinux
codepage:               0
countrycode:            0
distinguishedname:      CN=rbcdFromLinux,CN=Computers,DC=EVILCORP,DC=LOCAL
dscorepropagationdata:  1601-01-01 00:00:00
instancetype:           4
iscriticalsystemobject: FALSE
isgroup:                False
lastlogoff:             1600-12-31 18:00:00
lastlogon:              1600-12-31 18:00:00
localpolicyflags:       0
logoncount:             0
ms-ds-creatorsid:       S-1-5-21-3737425248-4185734480-769832259-1156
name:                   rbcdFromLinux
objectcategory:         CN=Computer,CN=Schema,CN=Configuration,DC=EVILCORP,DC=LOCAL
objectclass:            top,
                        person,
                        organizationalPerson,
                        user,
                        computer
objectguid:             e4df1e58-e0c2-44f5-9083-84cdb60e8858
objectsid:              S-1-5-21-3737425248-4185734480-769832259-1190
primarygroupid:         515
pwdlastset:             1600-12-31 18:00:00
samaccountname:         rbcdFromLinux$
samaccounttype:         805306369
useraccountcontrol:     ['PASSWD_NOTREQD', 'WORKSTATION_TRUST_ACCOUNT']
usnchanged:             27348
usncreated:             27345
whenchanged:            2021-05-11 06:44:42
whencreated:            2021-05-11 06:44:42

貢獻者指南

技術棧: python
領域: backendsecurity
議題類型: bug
難度: 3
預計時間: half day
活動狀態: stale
清晰度: mostly clear
前置要求: Pythonimpacket basicsSAMR protocolActive Directory attributes
新手友善度: 20
研究方向: The issue reports that addcomputer.py using the SAMR method creates a computer object but does not set attributes like dnsHostName and servicePrincipalNames. The expected behavior is for these attributes to be populated based on the computer name. Investigate lines 217-229 of addcomputer.py where attribute setting is attempted. Ensure the SAMR calls properly update the object after creation. Review the SAMR protocol implementation in impacket to find the missing attribute writes. Consider adding a SAMR domain user modification step after account creation.