foam-framework/foam

Should clone() run initializers? ... probably by issuing a create()?

Open

#425 建立於 2015年10月8日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)JavaScript (789 star) (57 fork)batch import
bughelp wantedquestion

描述

@jacksonic, @adamvy, and I were discussing this today. We've noted that dynamicValue() breaks init() doesn't run on objects that come out of a DAO that produces clones. We are pretty confident that this is because clone() doesn't actually create() a new object, and that it probably should.

@kgrgreer, can you offer your thoughts on this?

貢獻者指南

技術棧
javascript
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
Understanding of Foam object modelKnowledge of clone() and create() methods
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the clone() method implementation in the FOAM framework, likely in files related to object creation and initialization. Review the discussion in the issue and any linked comments. Look at the dynamicValue() function to understand how it breaks when init() is not run. Consider modifying clone() to call create() under the hood to ensure initializers run. Consult maintainer @kgrgreer for acceptance criteria.
Should clone() run initializers? ... probably by issuing a create()? · foam-framework/foam#425 | Good First Issue