flameshot-org/flameshot

SVG optimization made some icons unreadable

開放

#3,247 建立於 2023年6月28日

 (3 則留言) (0 個反應) (0 位負責人)C++ (1,916 個分叉)batch import
BugHelp WantedVisuals

倉庫指標

星標
 (29,897 顆星)
PR 合併指標
 (平均合併 2天 23小時) (30 天內合併 12 個 PR)

描述

While trying to use some of the SVGs created for buttons on the webpage, I realized the img/buttonIconsBlack/square.svg with following code does not render in Firefox:

https://github.com/flameshot-org/flameshot/blob/236534b17b0318b05b4e28bb906c38c78bae84de/data/img/material/black/square.svg#L1C1-L3C7 :

<svg viewBox="0 0 24 24">
    <path d="M3,3V21H21V3"/>
</svg>

But the same file before the #281 (commit d09580b) with the following content work just fine:

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="24" height="24" viewBox="0 0 24 24"><path d="M3,3V21H21V3" /></svg>

The working icon: , the broken icon:

There are two SVG files in the line above but one of them is rendered in the browser. View page source to confirm.

貢獻者指南