flameshot-org/flameshot

SVG optimization made some icons unreadable

Open

#3,247 建立於 2023年6月28日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (29,897 star) (1,916 fork)batch import
BugHelp WantedVisuals

描述

While trying to use some of the SVGs created for buttons on the webpage, I realized the img/buttonIconsBlack/square.svg with following code does not render in Firefox:

https://github.com/flameshot-org/flameshot/blob/236534b17b0318b05b4e28bb906c38c78bae84de/data/img/material/black/square.svg#L1C1-L3C7 :

<svg viewBox="0 0 24 24">
    <path d="M3,3V21H21V3"/>
</svg>

But the same file before the #281 (commit d09580b) with the following content work just fine:

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="24" height="24" viewBox="0 0 24 24"><path d="M3,3V21H21V3" /></svg>

The working icon: , the broken icon:

There are two SVG files in the line above but one of them is rendered in the browser. View page source to confirm.

貢獻者指南

技術棧
無
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic SVG knowledgeedit XML files
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue identifies that the SVG file 'data/img/material/black/square.svg' lacks required XML attributes (xmlns, width, height) due to optimization in commit d09580b. To fix, add the missing attributes: xmlns="http://www.w3.org/2000/svg" width="24" height="24". Also check other SVGs in the same directory that may have been affected by the same optimization and apply similar fixes if needed. No maintainer response is required as the problem and solution are clearly described.