flameshot-org/flameshot

Esc undo all my input when I select text tool

Open

#2,499 建立於 2022年3月22日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)C++ (29,897 star) (1,916 fork)batch import
EnhancementGood first issue

描述

Flameshot Version

Flameshot v11.0.0 (ad1bf28) Compiled with Qt 5.15.2 darwin: 21.2.0 osx: 12.1

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

MacOS

Description

When I try to add some text in the screenshot, suppose I am tying

"hello", then I type Esc key.

Then all my input would become lost. What my expectations should be "hello" is added into the screenshot and exit the text adding mode.

Is there anyway I could work around this?

Steps to reproduce

  1. Screenshot
  2. Click "add text" tool
  3. Type "hello"
  4. Type Esc key.

Screenshots or screen recordings

No response

System Information

Mac OS 12.1 (21C52)

貢獻者指南

技術棧
cpp
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic C++Qt event handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The bug is that pressing Esc while typing in the text tool clears the input. The fix should preserve the entered text when Esc is used to exit the text tool. Investigate the key press event handling in the text tool widget (likely in src/tools/text/textwidget.cpp or similar). Ensure that Esc triggers exit but does not discard the text. Consider using a modal state or confirming exit if text is present.