firefox-devtools/profiler

Repeated invocations of processThreadCPUDelta during symbolication take up more time than necessary

開放

#3,481 建立於 2021年8月5日

 (4 則留言) (0 個反應) (0 位負責人)TypeScript (486 個分叉)auto 404
help wantedperfprofile data

倉庫指標

星標
 (1,515 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Profile: https://share.firefox.dev/2X0vayw

Every time symbolication updates the thread, processThreadCPUDelta is called again for the modified profile. It seems like this is something that could be done only once. We could bake the guarantees that processThreadCPUDelta makes into the processed profile format. That means, instead of calling it from a selector, we would call it in these two places:

  • During profile processing, and
  • In an upgrader for the processed profile format.

It's not taking a ton of time, and symbolication is slow already, but it's one of many things that adds up to the slowness and it might be easy to fix.

┆Issue is synchronized with this Jira Task

貢獻者指南