firefox-devtools/profiler

Clean up the fallback label code for FileIO markers

開放

#3,131 建立於 2021年1月15日

 (3 則留言) (0 個反應) (0 位負責人)TypeScript (486 個分叉)auto 404
code maintenancehelp wantedmarkersneeds gecko patch

倉庫指標

星標
 (1,515 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

In the following code, we have some fallback code dedicated to FileIO markers: https://github.com/firefox-devtools/profiler/blob/c87e4e9127aa1f2e423dd81712cc4f829cf24e6f/src/profile-logic/marker-schema.js#L279-L289

This doesn't seem necessary nowadays as this could be implemented as a schema. The work here is:

  1. implement in gecko the schema that does this. (or check that it's implemented)
  2. remove the aforementioned fallback code
  3. add migration steps to both gecko and processed profile versioning to add the data to marker schemas from older profiles.
  4. possibly add tests if there's some missing for this case

┆Issue is synchronized with this Jira Task

貢獻者指南