firecracker-microvm/firecracker

Use `clippy::as_conversions`

Open

#3,161 建立於 2022年10月4日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Rust (34,348 star) (2,393 fork)batch import
Good first issuePriority: LowStatus: ParkedType: Fix

描述

From a discussion https://github.com/firecracker-microvm/firecracker/pull/3156#discussion_r986640407 it was thought utilizing the clippy lint clippy::as_conversions would introduce additional safety.

It would be good to implement this lint, either via #![warn(clippy::as_conversions)] or passed as a command line argument under test_clippy.py.

To break up this work, we can implement the following lints incrementally:

  • #3195
  • #3196
  • #3197
  • #3198
  • #3199
  • #3200
  • #3201
  • #3202
  • #3203
  • In Cargo.toml replace 
    ptr_as_ptr = "warn"
cast_lossless = "warn"
cast_possible_truncation = "warn"
cast_possible_wrap = "warn"
cast_sign_loss = "warn"
    with 
    as_conversions = "warn"
    and fix warnings.

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programming languageClippy lint tool
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The remaining work is to modify the `Cargo.toml` file to replace the list of individual clippy lints with `as conversions = "warn"`, and then fix any warnings that arise from enabling this lint. Start by examining the current lint configuration in `Cargo.toml` and the linked discussion at https://github.com/firecracker microvm/firecracker/pull/3156#discussion r986640407 for context. Run `cargo clippy` locally after making the change to identify and resolve new warnings.