finos/morphir-elm

Merge Record and ExtensibleRecord types in the IR

開放

#166 建立於 2020年9月30日

 (2 則留言) (0 個反應) (0 位負責人)Elm (69 個分叉)auto 404
good first issuehelp wantedir-simplification

倉庫指標

星標
 (51 顆星)
PR 合併指標
 (平均合併 3小時 4分鐘) (30 天內合併 2 個 PR)

描述

Currently there are two separate constructors for Record and ExtensibleRecord in the IR: https://github.com/finos/morphir-elm/blob/55f27570f971e8c4e12fe1a0346dffdce594869e/src/Morphir/IR/Type.elm#L89-L90

These correspond to the following Elm code (excluding the left-hand-side):

type alias MyRecord =
    { foo : String
    }

type alias MyExtensibleRecord e =
    { e
        | foo : String
    }

The structure and semantics of the two definitions are very similar and in most cases the code that operates on them will share most of the logic so merging them will make the IR smaller and easier to process. This is one way to represent both with a single constructor:

    | Record a (Maybe Name) (List (Field a)) 

Acceptance Criteria

貢獻者指南