feathr-ai/feathr

Add guardrails for materialize different keys

Open

#529 建立於 2022年7月29日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Scala (1,929 star) (244 fork)batch import
good first issuepython

描述

In theory, we can't materialize features of different keys into same online table as tables are always keyed by same key.

In the documentation, we do warn users not to materialize different keys to same table.

Right now, if users materialize features to the same table, a random group of the same key will materialize to the table. The other different groups will be discarded. The documentation is not fool-proof enough, so we should throw exception when users do this.

The code to modify is: https://github.com/linkedin/feathr/blob/main/feathr_project/feathr/client.py#L558

貢獻者指南

技術棧
python
領域
backenddata
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Python basicsFeathr client understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue points to line 558 in feathr project/feathr/client.py. The task is to add a guardrail that raises an exception when users try to materialize features with different keys into the same online table. Look at the current materialize method and add a check for key consistency. Consider writing a unit test to verify the behavior.
Add guardrails for materialize different keys · feathr-ai/feathr#529 | Good First Issue