feathr-ai/feathr

Path concatenation without forward slash

Open

#297 建立於 2022年5月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Scala (1,929 star) (244 fork)batch import
featuregood first issue

描述

This is reported by Manjunath from Slack channel. For work_dir: "dbfs:/feathr_getting_started" The user was running jupyter notebook from windows. without forward slash('dbfs:/feathr_getting_started') the job configs were coming as '--join-config', 'dbfs:/feathr_getting_started\feature_join.conf'

To fix this, the user need to add foward slash: work_dir: "dbfs:/feathr_getting_started"

We should add validation or automatically append a forward slash. The best way would be using Path utils that can join files/folders properly.

貢獻者指南

技術棧
scalapythonspark
領域
data
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue is about path concatenation errors when work dir lacks a trailing slash. The fix should involve adding validation or using path joining utilities (e.g., os.path.join in Python, Path in Scala) to ensure proper joining. Look at the configuration handling code, possibly in the Python SDK or Scala job submission components. Test on Windows to confirm the fix.
Path concatenation without forward slash · feathr-ai/feathr#297 | Good First Issue