facebookexperimental/Recoil

Memory leak when using atomFamily/selectorFamily

Open

#366 建立於 2020年6月19日

在 GitHub 查看
 (22 留言) (13 反應) (1 負責人)JavaScript (19,428 star) (1,151 fork)batch import
help wantedperformance

描述

Hello there,

The resources created by atomFamily and selectorFamily are not being properly freed when the specific key changes or if the component using the related RecoilState<T> unmounts.

Since I believe that memory management isn't properly implemented yet, both utils should be marked as _UNSAFE.

https://codesandbox.io/s/cranky-booth-penix?file=/src/App.js

貢獻者指南

技術棧
javascriptreact
領域
frontendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactRecoilMemory management in JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue describes a memory leak in atomFamily and selectorFamily where resources are not freed when keys change or components unmount. Review the Recoil source code in the src directory (e.g., src/shared/AtomFamily.js or src/shared/SelectorFamily.js) to understand how atoms and selectors are created and stored. Check existing comments and the linked CodeSandbox for reproduction steps. Note that the issue has an assignee, so reach out to them or maintainers before starting work.