facebookexperimental/Recoil

[Performance] Short-circuit set recoil state if the value is unchanged

Open

#1,927 建立於 2022年7月30日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)JavaScript (19,428 star) (1,151 fork)batch import
help wantedperformance

描述

It seems that the current implementation of setting recoil state can be further improved when the value is the same as the current value. In this case, we don't have to go through all the enchilada and more importantly don't have to call setState in the end, which is not exactly cost free. I have observed major performance hit thanks to that. I have to cache the previous value myself and do the equality check before calling set recoil state when recoil has all the knowledge to that.

貢獻者指南

技術棧
javascriptreact
領域
performancefrontend
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptReactRecoil fundamentals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Look at the Recoil source code related to state updates, specifically the `setRecoilState` function. Identify where the state is updated and add an equality check to short circuit if the value is unchanged. Consider using a shallow comparison for objects. Check existing comments for additional context.