facebookarchive/prepack

Create smoke-test for prepack-node

Open

#693 建立於 2017年6月1日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (14,268 star) (520 fork)batch import
help wantedtest needed

描述

A recent change to the code resulted in PrepackFile throwing an exception whenever it's invoked (see fix in #691 ), but that was not detected by any of our tests. We should add a basic smoke test for each of the exported functions from prepack-node (prepackStdin, prepackFile, and prepackFileSync) to allow for such clear-cut breaks to be automatically caught by testing.

貢獻者指南

技術棧
javascriptnodejs
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue requests adding smoke tests for the three exported functions of prepack node: prepackStdin, prepackFile, and prepackFileSync. A previous fix (#691) was not caught by tests, so these tests are needed. The code is likely in a prepack node directory. The contributor should set up a testing environment and write basic tests that call each function to ensure they don't throw exceptions.