facebookarchive/prepack

Generate CommonJS Module Compatible Output

Open

#451 建立於 2017年4月25日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (14,268 star) (520 fork)batch import
enhancementhelp wanted

描述

Currently we generate output that ends with .call(this). This works fine in a global context. It would, however, be nice to be able to generate an output that doesn't assume that this is the global context so that it can run inside of a "module" and still be able to reach for the global object. In this context this is something else.

Perhaps we can detect if the global variable is available in the scope and conditionally use that? Otherwise fallback to this? I.e. .call(global || this)

cc @kittens

貢獻者指南

技術棧
javascript
領域
clibuild system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptCommonJSglobal object
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue proposes modifying the generated output to use `global || this` instead of just `this` to support CommonJS modules. The change is likely in the code that generates the final invocation, possibly in the bundle output function. Review the existing codebase to locate where `.call(this)` is emitted and implement the fallback. Test with both global and module contexts to ensure correctness.