facebookarchive/prepack

Prepack emits code containing invalid global.TypedArray access

Open

#2,292 建立於 2018年7月18日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (14,268 star) (520 fork)batch import
bughelp wantedinterpreter

描述

TypedArray is a global not exposed to the user JavaScript runtime. Try global.TypedArray in your JavaScript environment of choice. We must emit Object.getPrototypeOf(Int8Array) or similar instead of TypedArray.

Input

var TypedArray = Object.getPrototypeOf(Int8Array);
console.log(TypedArray.from.name === "from");

Output

var TypedArray;
(function() {
  var _$0 = this;

  var _$1 = _$0.TypedArray; // <-------------------- `TypedArray` is not exposed on the global object!
  _$0.TypedArray = _$1;
  console.log(true);
}.call(this));

貢獻者指南

技術棧
javascriptnodejs
領域
build system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of JavaScript prototypesFamiliarity with Prepack's code generation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue is that Prepack incorrectly emits `global.TypedArray` instead of a valid expression like `Object.getPrototypeOf(Int8Array)`. To fix, locate where Prepack serializes global object property accesses and replace the usage of `TypedArray` with a reference that works in all JavaScript environments. The relevant code is likely in the serializer or environment module of Prepack. Check the source files in the `lib/` directory for handling of built in objects. The fix should ensure that the emitted code does not assume `TypedArray` is a global.
Prepack emits code containing invalid global.TypedArray access · facebookarchive/prepack#2292 | Good First Issue