facebookarchive/prepack

realm.$TemplateMap is persistent throughout effects

Open

#2,129 建立於 2018年6月18日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (14,268 star) (520 fork)batch import
abstractbughelp wantedinterpreterlevel 2 (easy)

描述

Using ES2015 tagged template literals makes use of a $TemplateMap on the realm. When we evaluateForEffects and create a tagged template inside some effects, then revert the effects, it's expected that the newly created array objects in the template map are also stored on effects and properly reverted.

貢獻者指南

技術棧
javascript
領域
build systemperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of JavaScript template literalsFamiliarity with prepack's effect system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue is about tagged template literals and the `$TemplateMap` on the realm. Investigate the effect system in prepack, specifically how effects are created and reverted when evaluating tagged templates. Look at the relevant source files in the repository, likely in the effects or realm modules, to understand how `$TemplateMap` entries are managed. There are no comments or linked PRs, so the fix requires a thorough understanding of the codebase.