facebookarchive/prepack

Make Prepack heap graph visualization to be consistently with different serialization options

Open

#1,309 建立於 2018年1月2日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (14,268 star) (520 fork)batch import
bughelp wantedwebsite

描述

Currently, Prepack heap graph visualization is based on the default Prepack mode so it may diverge from the real generated code when options are applied. For example, when --inlineExpressions is applied, many objects are inlined into its parent object so there is no identifier generated for it while heap visualization still shows their identifiers which is confusing.(Not sure what to show though).

Here are some options that may change the graph but not well tested:

  1. --inlineExpressions.
  2. --debugNames
  3. --additionalFunctions.
  4. --react

For this issue, we should a least fix for "--inlineExpressions" since it is default on website. Also, we should make heap visualization feature is disabled when "--additionalFunctions/--react" is specified since we haven't tested it yet.

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Prepack serialization optionsHeap graph visualization code
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Start by examining the heap graph visualization code in the Prepack repository. Look for the module responsible for generating the visualization and see how it currently uses serialization options, particularly inlineExpressions. Check the options parsing code to understand how to conditionally enable/disable features. Also, review any existing tests for visualization consistency. Since the repository is archived, consider whether changes are still desired, but for this issue, the goal is to make the visualization reflect the actual output of different options.