Make Prepack heap graph visualization to be consistently with different serialization options
#1,309 建立於 2018年1月2日
倉庫指標
- Star
- (14,268 star)
- PR 合併指標
- (30 天內沒有已合併 PR)
描述
Currently, Prepack heap graph visualization is based on the default Prepack mode so it may diverge from the real generated code when options are applied. For example, when --inlineExpressions is applied, many objects are inlined into its parent object so there is no identifier generated for it while heap visualization still shows their identifiers which is confusing.(Not sure what to show though).
Here are some options that may change the graph but not well tested:
- --inlineExpressions.
- --debugNames
- --additionalFunctions.
- --react
For this issue, we should a least fix for "--inlineExpressions" since it is default on website. Also, we should make heap visualization feature is disabled when "--additionalFunctions/--react" is specified since we haven't tested it yet.