facebookarchive/draft-js

Indenting list block of one type inside the other

Open

#443 建立於 2016年6月5日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
enhancementhelp wanted

描述

If I create a OL of 2 items and change depth of 2nd item to 2, like this:

1. ITEM1
      2. ITEM2

If I change type of 2nd item to UL it looses it depth:

1. ITEM1

2. ITEM2

But now if I try to indent second item, it works

1. ITEM1

    2. ITEM2

While indenting its checked that block above is list, but its not checked if its list of same type. Also, please find gif attached. I can create a PR for the fix.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic understanding of ReactFamiliarity with Draft.js editor internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the Draft.js list indentation logic, specifically how block types are changed and depth is maintained. Look at the source files handling OL and UL block rendering, especially the 'RichTextEditor' or 'EditorState' utilities. The bug occurs when changing a list item type from OL to UL and the depth resets. Focus on the function that updates block type and its handling of depth. Examine the code in 'lib/EditorState.js' or similar that processes block metadata during type changes. The fix likely involves ensuring that the depth property is preserved when only the type field is modified.