facebookarchive/draft-js

moveSelectionBackward warning in production

Open

#1,840 建立於 2018年8月20日

在 GitHub 查看
 (5 留言) (2 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
help wanted

描述

Do you want to request a feature or report a bug? bug

What is the current behavior? backspacing in the editor causes the following warning in dev environment:

Draft.js:5665 Warning: moveSelectionBackward should only be called with a collapsed SelectionState

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.

  1. Open the official tweet.html example.
  2. Type "abcdefg"
  3. Press backspace Observe each time backspace is pressed there is a warning in the console log.

The warning is only shown in dev env. I haven't found any user facing issue caused by this.

What is the expected behavior? Shouldn't have warning in console log.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

There isn't this warning on the master of May 16, 2018, so it could be a regression.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of Reactfamiliarity with Draft.js
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The warning 'moveSelectionBackward should only be called with a collapsed SelectionState' appears in dev mode in Draft.js. To investigate, search for the string 'moveSelectionBackward' in the source code. Look at the function that calls it and ensure it checks for collapsed selection before calling. The issue might be in the 'handleBackspace' or related method. Since the repository is archived, consider if a fix is still feasible or propose a workaround.