facebookarchive/draft-js

Test for indenting list item more than one level

Open

#1,674 建立於 2018年3月2日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
good first issuehelp wantedtest coverage

描述

After we merge https://github.com/facebook/draft-js/pull/762 then Draft should support indentation of a list more than one item deep.

To make sure we don't regress this support in the future, let's add a test.

I would add a test in the suite of unit tests for RichEditorUtil, here -> https://github.com/facebook/draft-js/blob/master/src/model/modifier/__tests__/RichTextEditorUtil-test.js

We don't seem to have any test for 'onTab' so let's add one.

testing_i_love_testing

貢獻者指南

技術棧
reactjavascript
領域
frontendtesting
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of Draft.js editorFamiliarity with unit testing in React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review the linked PR #762 to understand the expected behavior for indenting list items more than one level. Then, open the file 'src/model/modifier/ tests /RichTextEditorUtil test.js' and add a new test case for the 'onTab' function. Follow the existing test patterns to ensure the test passes and covers the scenario.
Test for indenting list item more than one level · facebookarchive/draft-js#1674 | Good First Issue