facebookarchive/draft-js

Test to verify focus/scroll behavior

Open

#1,402 建立於 2017年9月22日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
help wantedtest coverage

描述

We have twice now had an issue where a change in Chrome breaks the scroll/focus behavior of Draft. See issues #14 and now https://github.com/facebook/draft-js/issues/1381.

It might not be easy, but I'd really like to get this covered by a test, so that we can know if/when it breaks again. Ideally would like both a unit test for focusNode in fbjs and a test that only uses the public API of Draft.js and reproduces an example similar to the one given in https://github.com/facebook/draft-js/issues/1381 .

It's true that these test would only start failing when run in the browser that has the inconsistency, but still would make it faster to verify and fix this type of problem.

貢獻者指南

技術棧
javascriptreact
領域
frontendtesting
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Draft.js public APIExperience with unit testing frameworksKnowledge of browser scroll/focus behavior
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requests two tests: a unit test for `focusNode` in fbjs (https://github.com/facebook/fbjs/blob/master/packages/fbjs/src/core/dom/focusNode.js) and a test using Draft.js public API to reproduce the scroll/focus issue from #1381 (https://github.com/facebook/draft js/issues/1381). Look at the linked issues #14 and #1381 for reproduction steps. The tests should be added to the Draft.js test suite. Since the repo is archived, ensure compatibility with existing test infrastructure.