facebookarchive/draft-js

Why is createEntity mutable?

Open

#1,256 建立於 2017年6月21日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
documentationhelp wanted

描述

Do you want to request a feature or report a bug? Question/bug

What is the current behavior? Calling contentState.createEntity actually modifies contentState object instead of just returning a new one. Here is a simple fiddle: https://jsfiddle.net/FredyCr/32vo35tk/2/

What is the expected behavior? I guess it's not a big deal, it's just little bit confusing given that almost every other operation is immutable.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? Working with the latest 0.10.1, not sure about previous versions.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptReactDraft.js basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the createEntity method in Draft.js's ContentState module to understand why it modifies the existing object. The issue reports that contentState.createEntity mutates the original object instead of returning a new one. Look for existing tests or discussions about immutability in the codebase, then implement a fix that returns a new ContentState with the entity added, ensuring backward compatibility.