facebookarchive/draft-js

Improve style by removing boolean param in `getCharacterRemovalRange.js`

Open

#1,116 建立於 2017年4月3日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (22,554 star) (2,646 fork)batch import
enhancementgood first issue

描述

A recent change added two boolean flag params to getCharacterRemovalRange.js. Boolean params generally make code less readable and maintainable - this is not worth blocking a PR at this time, but it would be great to update this file and the callsites to call two methods instead of passing in different boolean params.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactJavaScriptfamiliarity with draft js codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Review the changes in PR #1108 that added boolean params to getCharacterRemovalRange.js. Then refactor the function to split into two methods (e.g., for forward and backward deletion) and update all callsites. Ensure existing tests pass and add tests if needed. See issue comments for discussion.