facebookarchive/atom-ide-ui

Consider allowing HTML in datatip markdown

開放

#99 建立於 2017年10月18日

 (9 則留言) (4 個反應) (0 位負責人)JavaScript (110 個分叉)batch import
datatipsenhancementhelp wanted

倉庫指標

星標
 (937 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Description

I noticed that markdown in datatips sanitizes out HTML. I can understand this, but would like to request the ability to disable this, perhaps in the datatip or MarkedString data itself.

The reason for this is, at least in PHP, docblock comments can intermingle markdown and HTML and one codebase may decide to use markdown whilst one of its dependencies may resort solely to HTML.

I see that datatips uses the marked library, which I am currently also using. It should already allow this by simply not requesting sanitization of the input value. (In the end, the embedded HTML is just more HTML to be displayed in the datatip after the markdown has been converted.)

Expected Behavior

HTML would not be sanitized or there would be an option to disable it for datatip markdown strings.

Actual Behavior

HTML is always sanitized in datatip markdown strings.

Versions

  • Atom: 1.21.0
  • Client OS: Linux
  • atom-ide-ui: 0.5.1

貢獻者指南