facebookarchive/atom-ide-ui

Allow code format providers to return null to 'fall through'

Open

#26 建立於 2017年9月13日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (937 star) (110 fork)batch import
code formatenhancementhelp wanted

描述

Code format providers are currently forced to return something: https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/types.js

However, this makes it difficult to have multiple formatting providers for the same document, since we only use the one with the highest priority.

Instead, we should use ProviderRegistry.getAllProvidersForEditor (e.g. on https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/CodeFormatManager.js#L257) and take the first one with a non-nullable result.

cc @damieng

貢獻者指南

技術棧
javascript
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of Atom IDE plugin architectureFamiliarity with ProviderRegistry
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
This issue suggests modifying CodeFormatManager.js to use ProviderRegistry.getAllProvidersForEditor and iterate through providers, taking the first non null result. The change is localized to the module referenced in the issue. First, understand the current flow in CodeFormatManager.js at line 257 and the types.js file. Then implement fallback logic as described.