facebook/zstd

Refactor ZSTD_estimateCCtxSize_usingCCtxParams_internal()

Open

#3,404 建立於 2022年12月28日

在 GitHub 查看
 (5 留言) (1 反應) (1 負責人)C (27,100 star) (2,481 fork)batch import
enhancementgood first issuelong-term

描述

ZSTD_estimateCCtxSize_usingCCtxParams_internal() currently takes a long list of parameters. Some (all?) of the parameters are extracted from external ZSTD_CCtx_params objects and passed in one by one. It would be cleaner to reduce the number of parameters by directly passing in a ZSTD_CCtx_params const*.

This should be an easy refactor. Code pointer: https://github.com/facebook/zstd/blob/90597d78eadadae7acf3633ab4d81ef7c4e6057f/lib/compress/zstd_compress.c#L1488-L1495

貢獻者指南

技術棧
c
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingbasic understanding of zstd
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Modify the function signature of ZSTD estimateCCtxSize usingCCtxParams internal in lib/compress/zstd compress.c (line 1488) to accept a const pointer to ZSTD CCtx params instead of the individual parameters. Then update all callers of this function to pass the pointer. There may be internal and external callers to consider. Ensure the change is consistent with the existing code style and passes tests.
Refactor ZSTD_estimateCCtxSize_usingCCtxParams_internal() · facebook/zstd#3404 | Good First Issue