facebook/zstd

Inclusion of Bazel build files in official zstd library

Open

#3,123 建立於 2022年5月2日

在 GitHub 查看
 (13 留言) (3 反應) (0 負責人)C (27,100 star) (2,481 fork)batch import
buildfeature requesthelp wanted

描述

Is your feature request related to a problem? Please describe. I need to use this library to build RocksDB. We use bazel to build everything, which means zstd must build with bazel.

Currently we are achieving bazel builds by pulling in https://github.com/cschuet/zstd/pull/2, which tends to go stale.

Describe the solution you'd like Add a BUILD.bazel and WORKSPACE file to the zstd repo. Bazel users can use this and help maintain it.

Describe alternatives you've considered

  1. Out-of-repository bazel projects like https://github.com/cschuet/zstd/pull/2
  2. Using CMake (or whatever zstd uses) within bazel.

I know only a casual amount about the C++ build ecosystem, so I'm not sure what all the options are. Bazel is nice because users can issue a uniform set of commands across all languages, so I don't /have/ to know the C++ ecosystem to build C++ tools

Additional context Would the authors accept a pull request with BUILD.bazel and WORKSPACE files?

See https://github.com/cschuet/zstd/blob/02cedda8da27c2043166dec046599e13da4a68b6/bazel/third_party/zstd.BUILD for expected contents.

貢獻者指南

技術棧
c
領域
build system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Bazel build systemC library structureFamiliarity with Makefile or CMake
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue requests adding BUILD.bazel and WORKSPACE files to enable Bazel builds. The referenced PR at cschuet/zstd provides a template (https://github.com/cschuet/zstd/blob/02cedda8da27c2043166dec046599e13da4a68b6/bazel/third party/zstd.BUILD). Contributors should examine the zstd source structure, understand the existing build system (Makefile/CMake), and create equivalent Bazel rules. The maintainers have not explicitly accepted or rejected the request, so research into prior discussions in comments is needed.