facebook/prop-types

React Portals can't be validated with prop-types

Open

#167 建立於 2018年3月1日

在 GitHub 查看
 (4 留言) (17 反應) (0 負責人)JavaScript (4,379 star) (389 fork)batch import
bughelp wanted

描述

PropTypes.node is not accepting element, created by React.createPortal as valid

Is it possible to treat element created by React.createPortal as iterator over it's children or treat portal itself as valid node?

貢獻者指南

技術棧
reactjavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ReactUnderstanding of React PortalsFamiliarity with prop types API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the PropTypes.node implementation in the prop types library, specifically the isNode validator. Examine how React Portals are represented (as objects with a $$typeof). Determine if the validator can be extended to treat portals as valid nodes. Consider referencing the React source for createPortal.
React Portals can't be validated with prop-types · facebook/prop-types#167 | Good First Issue