facebook/fresco

SvgDecoderExample limit <svg tag

Open

#2,490 建立於 2020年4月20日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Java (17,072 star) (3,750 fork)batch import
enhancementgood first issuehelp wanted

描述

We use GitHub Issues for bugs.

If you have a non-bug question, please ask on Stack Overflow: http://stackoverflow.com/questions/tagged/fresco

--- Please use this template, and delete everything above this line before submitting your issue ---

Description

I want use SimpleDraweeView to .setImageURI(Uri.parse("https://www.ups.com/assets/resources/images/UPS_logo.svg")); but the svg file is start with <?xml tag, so SvgDecoderExample.SvgFormatChecker() is block it.

Solution

I try update SvgDecoderExample.java line 33 : private static final String HEADER_TAG = "<svg"; to private static final String HEADER_TAG = "<?xml"; let it thought the cheker, it is visible now.
why you want to block the tag?
The AndroidSVG('com.caverock:androidsvg:1.2.1') lib is work find.

Additional Information

  • Fresco version: 'com.facebook.fresco:fresco:2.0.0'

貢獻者指南

技術棧
javaandroid
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaAndroid
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is in SvgDecoderExample.java on line 33 where the constant HEADER TAG checks only for '<svg'. The reporter suggests changing it to '<?xml' or accepting both. The maintainer should confirm if files starting with <?xml are valid SVG and whether the fix should allow both patterns. Check the AndroidSVG library documentation for supported SVG root tags.