targetSdk 29 (scoped storage) support? · facebook/fresco#2455

(16 留言) (2 反應) (1 負責人)Java (17,072 star) (3,750 fork)batch import

enhancementgood first issuehelp wanted

描述

Description

Fresco failed to load images from EXTERNAL_CONTENT_URI e.g. content://media/external/images/media/8039, FileNotFoundException was seen from the logs

Reproduction

Loading images with EXTERNAL_CONTENT_URI content://media/external/images/media/8039

Solution

I found that inside com.facebook.imagepipeline.producers.LocalContentUriFetchProducer, given the above content uri, it will fall to the call getCameraImage and which in turn getting the absolute file path of the image. However, due to scoped storage in targetSdk 29, that wouldn't be allowed. Probably getting input stream like

ParcelFileDescriptor pfd = mContentResolver.openFileDescriptor(contentUri, "r");
FileInputStream fis = FileInputStream(pfd.getFileDescriptor());

Additional Information

Fresco version: 2.0.0
Platform version: Android 10

貢獻者指南

技術棧: javaandroid
領域: mobile
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: blocked
清晰度: clear
前置要求: Android developmentContentResolver usageFresco image pipeline basics
新手友善度: 35
研究方向: The issue is in `LocalContentUriFetchProducer.java`. The current implementation uses `getCameraImage` which fails on Android 10+ due to scoped storage. The solution involves using `ContentResolver.openFileDescriptor` to get a `ParcelFileDescriptor` and then a `FileInputStream`. The issue has an assignee, so check if they have made progress or if the fix is pending review. Also review the discussion comments for any additional context or alternative approaches.