ethereum/mist

Use electron builder NSIS installer

Open

#4,037 建立於 2018年7月30日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)JavaScript (7,425 star) (2,263 fork)batch import
Module: Build processOS: Windowshelp wanted

描述

Currently, our build process takes care of building NSIS (windows installer) on its own. We should migrate it to electron-builder way, to simplify our process and take advantage of electron-builder code signing functionality (#3444).

  • add NSIS target to the list
  • port this nsi script to the new solution
  • remove build-nsis from gulp tasks.

Where to begin: Looking at gulpFile.js and w

Related code:

貢獻者指南

技術棧
javascriptelectron
領域
desktoprelease
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
electron builder basicsgulp task understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Review gulpfile.js (line 85) and gulpTasks/building.js (lines 144, 282-295) to understand current NSIS handling. Examine windows installer.nsi script to be ported. Add NSIS target to electron builder config, port the script, and remove build nsis gulp tasks. Note that the repository is deprecated; verify with maintainers if the change is still desired.