etcd-io/etcd

Enable `unexported-return` linter rule

Open

#18,370 建立於 2024年7月26日

在 GitHub 查看
 (24 留言) (0 反應) (2 負責人)Go (10,352 fork)batch import
area/testinghelp wantedpriority/important-longtermtype/cleanup

倉庫指標

Star
 (51,701 star)
PR 合併指標
 (平均合併 6天 3小時) (30 天內合併 71 個 PR)

描述

What would you like to be added?

There are two remaining linter rules that we haven't enabled but are left as TODO (./tools/.golangci.yaml): exported and unexported-return. The former will have significant changes to exported functions and interfaces. The latter, even though it impacts exported structs, it's for the better (it exposes them without breaking client implementations).

I suggest breaking the pull requests into small tasks like we did on #17578.

The following modules have warnings to be addressed:

  • api - #18645
  • pkg
  • client/pkg
  • client/v3
  • server - #19052
  • tests
    • #19105

Refer to the attached log file with the result from KEEP_GOING_MODULE=true make verify-lint.

Why is this needed?

To improve the quality of the code.

貢獻者指南