equinor/ert

Add basic validations to ForwardModelStepPlugin such as executable exists

開放

#8,779 建立於 2024年9月24日

 (0 則留言) (0 個反應) (0 位負責人)Python (136 個分叉)auto 404
good first issuemaintenanceneeds-discussion

倉庫指標

星標
 (157 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

What happened? (You can include a screenshot if it helps explain)

A user can create a ForwardModelStepPlugin to use in Ert with a bad path to an executable, and this will not be validated before it blows up mid run. Discuss whether we should add this validation or not, or whether this is Ert's responsibility in the ForwardModelStepPlugin constructor, or the FM implementor's responsibility through the ForwardModelStepPlugin.validate_pre_experiment(...) api.

It should at most be a warning, because there can be forward models preceding this one that creates the necessary files/executables.

See previous discussion under PR: https://github.com/equinor/ert/pull/8735

What did you expect to happen?

Warning if a non existent executable is provided, with a explanation that it might be ok

steps to reproduce

Create a forward model step plugin with a bad executable.

Environment where bug has been observed

  • python 3.8
  • python 3.9
  • python 3.10
  • python 3.11
  • python 3.12
  • macosx
  • rhel7
  • rhel8
  • local queue
  • lsf queue
  • slurm queue
  • openPBS queue
  • used flag --enable-scheduler

貢獻者指南