enzymejs/enzyme

Upgrading from enzyme-adapter-react-16@1.15.1 -> 1.15.2 breaks connected component tests

Open

#2,390 建立於 2020年4月27日

在 GitHub 查看
 (15 留言) (0 反應) (0 負責人)JavaScript (19,979 star) (2,016 fork)batch import
Need To Reproducehelp wantedpackage: react adapter: 16

描述

Current behavior

When I upgrade from 1.15.1 of enzyme-adapter-react-16 to version 1.15.2, I am running into JSX comparison test failures with connected components.

Ex.

  const wrapper = shallow(<SomeComponent />).get(0);
  expect(wrapper).toEqualJSX(
    <ConnectedRouter history={history}>
          ...childrenHere
    </ConnectedRouter>
  )

// FAILURE
- <ConnectFunction
+ <Connect(ConnectedRouterWithContext)

Note: toEqualJSX -> https://www.npmjs.com/package/jasmine-expect-jsx is a simple wrapper around react-element-to-jsx-string -> https://github.com/algolia/react-element-to-jsx-string and turns a react element into a JSX string.

Expected behavior

Expect tests to still pass without change after bumping minor version

Your environment

API

  • shallow
  • mount
  • render

Version

library version
enzyme 3.11.0
react 16.13.1
react-dom 16.13.1
react-test-renderer 16.13.1
adapter (below) 1.15.2

Adapter

  • enzyme-adapter-react-16
  • enzyme-adapter-react-16.3
  • enzyme-adapter-react-16.2
  • enzyme-adapter-react-16.1
  • enzyme-adapter-react-15
  • enzyme-adapter-react-15.4
  • enzyme-adapter-react-14
  • enzyme-adapter-react-13
  • enzyme-adapter-react-helper
  • others ( )

貢獻者指南

技術棧
javascriptreact
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ReactFamiliarity with enzyme shallow rendering
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the changes between enzyme adapter react 16 versions 1.15.1 and 1.15.2, focusing on display name handling for connected components. The git diff or changelog may reveal modifications in the adapter's rendering logic that altered the component representation from 'ConnectedRouterWithContext' to 'ConnectFunction'. Examining the adapter's source code in the `src/` directory, particularly files related to rendering and component identification, could help identify the exact change.