enzymejs/enzyme

React Elements returned by enzyme in v3 are missing context

Open

#1,344 建立於 2017年11月10日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (19,979 star) (2,016 fork)batch import
API: shallowhelp wantedv3 bugs

描述

In v2, if you wanted to get the underlying element, it contained the element's context. In v3, there is no context.

I believe for shallow, we just need to add it here https://github.com/airbnb/enzyme/blob/master/packages/enzyme-adapter-react-16/src/ReactSixteenAdapter.js#L224

For mount, it's a few places (in those toTree functions).

I think it'd be nice to have the context on the element though so that it's closer to the real element.

Thoughts?

貢獻者指南

技術棧
reactjavascript
領域
frontendtesting
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React contextEnzyme shallow adapterEnzyme mount toTree
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the shallow rendering adapter in packages/enzyme adapter react 16/src/ReactSixteenAdapter.js around line 224 to understand how elements are constructed. For mount, locate the toTree functions in the same adapter or elsewhere and add context to the returned element. Review any existing discussion in comments for implementation details.