envoyproxy/envoy

CacheFilter: Parse and handle precondition request headers

Open

#9,855 建立於 2020年1月28日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
area/cachehelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

CacheFilter (#7198) must fully parse and handle precondition request headers (RFC7232): if-match, if-none-match, if-modified-since, if-unmodified-since, and if-range.

This must be fixed before CacheFilter can be appropriate for production deployment.

We currently ignore these headers, which is incorrect, and will result in serving wrong content from cache. As a temporary shortcut, it would be acceptable to instead bypass caching for requests with precondition header. This would reduce cache effectiveness and give clients an easy way to bypass cache, but would never cause incorrect results. With the shortcut, this issue would no longer block production deployment of CacheFilter.

貢獻者指南