envoyproxy/envoy

Fix inconsistency in rate limit filter names

Open

#8,799 建立於 2019年10月29日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)C++ (5,373 fork)batch import
area/ratelimitbeginnerhelp wantedtech debt

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Minor cleanup related to PR #8796, for HTTP filters we have envoy.rate_limit but for networking filters we have envoy.ratelimit. We should update the network filter to match HTTP/Thrift. In order to avoid naming collisions, the network filter should be updated to the new style of envoy.filters.network.rate_limit. This would involve

  1. Register a second definition of the rate limit filter's config factory with the new name.
  2. Deprecation period for the old config factory
  3. Removal of the old config factory

(while here, we could extend this to updating all the networking filter names to the new format, this one just stood out as a potential nuisance)

貢獻者指南