envoyproxy/envoy

Unexpected metric names when cluster name contains dot

Open

#5,239 建立於 2018年12月6日

在 GitHub 查看
 (11 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
bughelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Title: Unexpected metric names when cluster name contains dot

Description:

When cluster name contains dot, cluster-specific metric names are unexpected.

Repro steps:

Create a cluster with dots in its name, e.g. foo.example.com, and then look for cluster metrics like envoy.cluster.upstream_rq_xx

Expected:

The metric should be named envoy.cluster.upstream_rq_xx with tag envoy_cluster_name=foo.example.com

Actual:

The metric is named envoy.cluster.example.com.upstream_rq_xx with tag envoy_cluster_name=foo

貢獻者指南