envoyproxy/envoy

XRayConfig_SegmentFields can't be configured correctly from an xDS control plane

Open

#31,142 建立於 2023年12月1日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)C++ (5,373 fork)batch import
area/awsarea/tracingenhancementhelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Title: XRayConfig_SegmentFields can't be configured correctly from an xDS control plane

Description:

Currently the XRayConfig_SegmentFields.Origin and XRayConfig_SegmentFields.Aws fields will allow configuring that the trace segment comes from the correct origin as per the Optional Segment Fields in the AWS Segment fields documentation.

The aws object that needs to be sent to make this origin be considered valid requires the following data:

ecs – Information about an Amazon ECS container.
- container – The hostname of your container.
- container_id – The full container ID of your container.
- container_arn – The ARN of your container instance.

This is possible to do using sed and yaml on statically configured envoy hosts.

However, an xDS server cannot populate this with meaningful data and it should be handled internally by envoy's XRay tracing features. I believe that detecting the correct data should be up to each individual envoy proxy at runtime, and should not be configurable here either in the yaml or in the xDS gRPC structs.

Relevant Links:

貢獻者指南