envoyproxy/envoy
在 GitHub 查看stats: retain Scopes for some amount of time after the last reference to them is dropped, to avoid leaking data when xds removes a scope
Open
#23,619 建立於 2022年10月21日
area/statsenhancementhelp wantedno stalebot
倉庫指標
- Star
- (27,997 star)
- PR 合併指標
- (平均合併 8天) (30 天內合併 378 個 PR)
描述
Title: When an xDS update removes a cluster, any stats that get updated after the most recent sink or scrape will get dropped when the ScopeSharedPtr held in the cluster gets dropped.
Description:
To avoid this we should delay the destruction of the Scope for some time interval, perhaps a few minutes. We must be careful to accelerate the Scope destruction when the stats store gets destructed (server exit, or unit-test completion).