envoyproxy/envoy

Feature: auto_host_rewrite with STATIC clusters

Open

#23,131 建立於 2022年9月15日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
area/routerenhancementhelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Title: Feature: auto_host_rewrite with STATIC clusters

Description: The option auto_host_rewrite works only with STRICT_DNS and LOGICAL_DNS clusters. Is there a reason that auto_host_rewrite is not available for STRICT clusters also? We have a use case where we don't have DNS, just static IP endpoints. And we need the upstream request to contain in the authority the IP address of the selected host. Using the auto_host_rewrite would be ideal, but it does not work with STATIC clusters. We tried to use auto_host_rewrite with STRICT_DNS, and it works OK with ipv4 (apart from some extra DNS queries) but with ipv6 we stumbled upon https://github.com/envoyproxy/envoy/pull/18945. I was wondering whether it is a design decision to not allow auto_host_rewrite with STATIC clusters. Do you expect negative side-effects? Is just difficult to implement due to the code structure? Or simply it is just a feature that has not been implemented yet.

[optional Relevant Links:] https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-routeaction-auto-host-rewrite https://github.com/envoyproxy/envoy/pull/18945

貢獻者指南