envoyproxy/envoy

Why envoy behaves differently when envoy adds an error tag to trace according to HTTP and GRPC status?

開放

#15,883 建立於 2021年4月8日

 (2 則留言) (2 個反應) (0 位負責人)C++ (5,373 個分叉)batch import
area/tracingenhancementhelp wanted

倉庫指標

星標
 (27,997 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Description: Envoy adds an error tag to trace when HTTP status is 5xx (NOT when HTTP status is 4xx). On the other hand, envoy adds an error tag to trace when GRPC status is not "OK".

I think envoy should not adds an error tag to trace when GRPC status is such as "NOT_FOUND" or "PERMISSION_DENIED" because they are equivalent to HTTP status 4xx.

Is there any intention for this difference?

Relevant Links: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#what-data-each-trace-contains

貢獻者指南