envoyproxy/envoy
在 GitHub 查看Why envoy behaves differently when envoy adds an error tag to trace according to HTTP and GRPC status?
Open
#15,883 建立於 2021年4月8日
area/tracingenhancementhelp wanted
倉庫指標
- Star
- (27,997 star)
- PR 合併指標
- (平均合併 8天) (30 天內合併 378 個 PR)
描述
Description: Envoy adds an error tag to trace when HTTP status is 5xx (NOT when HTTP status is 4xx). On the other hand, envoy adds an error tag to trace when GRPC status is not "OK".
I think envoy should not adds an error tag to trace when GRPC status is such as "NOT_FOUND" or "PERMISSION_DENIED" because they are equivalent to HTTP status 4xx.
Is there any intention for this difference?
Relevant Links: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#what-data-each-trace-contains