Remove unused methods and exceptions from JsonObject · envoyproxy/envoy#14893 | Good First Issue

(0 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import

help wantedtech debt

倉庫指標

Star: (27,997 star)
PR 合併指標: (平均合併 8天) (30 天內合併 378 個 PR)

描述

Remove instance of loadFromString in header formatter and replace with protobuf . https://github.com/envoyproxy/envoy/blob/e073b325890542a3ce3bbc4eefb89a09f390f27e/source/common/router/header_formatter.cc#L61
Remove unused methods and the unsafe code that can throw exceptions such as the get[Type] methods that don't have defaults. https://github.com/envoyproxy/envoy/blob/0d5b470097d5e3645759e43414db8a7104aafb2e/include/envoy/json/json_object.h#L114

Follow-up to https://github.com/envoyproxy/envoy/pull/14467

貢獻者指南

研究方向: 從header formatter.cc中移除loadFromString方法，並用protobuf替換。然後移除json object.h中可能拋出異常的get[Type]方法。
技術棧: cpp
領域: backend
議題類型: 重構
難度: 2
預計時間: 1-3 小時
活動狀態: 活躍
清晰度: 清晰
前置要求: GitC++
新手友善度: 80