envoyproxy/envoy

[xds] ADS reject duplicate resources in grpc_mux

Open

#14,847 建立於 2021年1月28日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
area/xdsbughelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Title: in grpc_mux_impl, let's reject a resonse when we see duplicate resources.

Description: see https://github.com/envoyproxy/envoy/blob/main/source/common/config/grpc_mux_impl.cc#L224 We want to not "dedup" but reject the response here when the emplace fails

new_grpc_mux_impl seems doesnt have same issue as it push dup resources to each xds impl, where the dup resources gets rejected.

Repro steps:

send a discoveryResponse with multiple resources with the same name. Envoy accepts it silently.

貢獻者指南