envoyproxy/envoy

DNS config: validate mutually exclusive options when loading dns config.

Open

#13,512 建立於 2020年10月12日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
area/dnshelp wantedtech debt

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

#13074 added a config option that is mutually exclusive with the existing (resolvers, using tcp for resolution) dns config options. Currently using these options together results in a release assert being triggered.

This issue tracks adding a centralized config validation function that always runs on the main thread. This way the validation can safely throw an exception. When this validation is added the release assert in createDnsResolver can be deleted.

貢獻者指南