envoyproxy/envoy
在 GitHub 查看Fine grained logging via FANCY_LOG always evaluates macro arguments
Open
#12,885 建立於 2020年8月29日
area/envoy_loghelp wanted
倉庫指標
- Star
- (27,997 star)
- PR 合併指標
- (平均合併 8天) (30 天內合併 378 個 PR)
描述
The ENVOY_LOG macro without fine grained logging doesn't evaluate variadic
arguments when the log level squelches the message. When going through
FANCY_LOG however, that no longer holds. Variadic arguments are always evaluated
regardless of the log level involved. This could be problematic from a perf point of view.
Context: https://github.com/envoyproxy/envoy/pull/12830#issuecomment-681918730