envoyproxy/envoy

Redis Health Checks do not support ACL auth_username

Open

#11,736 建立於 2020年6月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
area/redishelp wanted

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

Title: Redis Health Checks do not support the Redis 6 ACL auth_username parameter

Description:

The only thing I was not able to handle in the previous PR #11408 is supporting auth_username for health checks. This is ok for our initial use case as we can grant the default user +ping permissions. That said, others might like this feature and I am happy to work on it.

https://github.com/envoyproxy/envoy/blob/master/source/extensions/health_checkers/redis/redis.cc#L4 is still using API V2 configuration for health checks and so I was not able to add auth_username to the proto or the impl.

I propose adding a V3 API for redis health checks that supports auth_username and make the associated changes, but I wanted to check with you on this approach before starting the work.

貢獻者指南