envoyproxy/envoy

signal handling: refactor some names for clarity

Open

#11,052 建立於 2020年5月4日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (5,373 fork)batch import
help wantedtech debt

倉庫指標

Star
 (27,997 star)
PR 合併指標
 (平均合併 8天) (30 天內合併 378 個 PR)

描述

While working on https://github.com/lyft/envoy-mobile/issue/831 @mattklein123 suggested disabling signal handling. I originally thought he meant the signal handling envoy has for fatal signals using SignalActions, which didn't make much sense in the context we were working in. While I should have understood he meant signal handling for termination, it didn't help that we have several places to "disable signals", and we do so in bazel config, via compiler directives, and in code. We could clean this up and specify which settings work on fatal signals, which on termination signals, etc.

貢獻者指南