envoyproxy/envoy
在 GitHub 查看server: Remove --restart-epoch command-line option because #9888 computes it automatically
Open
#10,139 建立於 2020年2月22日
area/statshelp wantedtech debt
倉庫指標
- Star
- (27,997 star)
- PR 合併指標
- (平均合併 8天) (30 天內合併 378 個 PR)
描述
Currently, a deployment using hot-restart specifies a --restart-epoch epoch_number as a command-line argument to the server. Once #9888 is merged, server.hot_restart_generation will be computed automatically, eliminating the need for scripting to bump the epoch manually.
We should probably not remove that command-line option, however, until sometime after #4980 is merged, because there will be a discontinuity in the server.hot_restart_generation stat.
Then there probably should be a merger of the two stats, eventually dropping one.