Faulty assertion in node on .mjs files · emscripten-core/emscripten#17465

(4 留言) (0 反應) (0 負責人)C++ (27,361 star) (3,519 fork)batch import

JavaScriptgood first bughelp wanted

描述

It turns out that node will disable the global require function on foo.mjs - that is just not defined there, unlike for foo.js. I guess mjs files are modules and require is not supposed to be used there. This ends up a problem for us since we have an assertion on it:

https://github.com/emscripten-core/emscripten/blob/a3d8979b38d2f655f59b040bfd32f562ebc92d03/src/shell.js#L196-L198

Removing that assertion is necessary to run an .mjs file in node with -sASSERTIONS.

We should probably just remove it?

This happens on binaryen CI which will manually builds an .mjs file by concatenating the emcc output with some extra code.

貢獻者指南

技術棧: javascriptnodejs
領域: clitooling
議題類型: bug
難度: 1
預計時間: under 1 hour
活動狀態: stale
清晰度: clear
前置要求: Node.js module systemJavaScript
新手友善度: 85
研究方向: The issue points to a specific assertion in shell.js (lines 196-198) that should be removed to allow .mjs files to run with sASSERTIONS in Node. The fix is straightforward: delete those lines. Before proceeding, check if any other code depends on the global require being defined. Also review the binaryen CI setup that triggered this issue to ensure compatibility.